fix(interpreter): preserve shopt options across exec() calls#1131
Merged
fix(interpreter): preserve shopt options across exec() calls#1131
Conversation
reset_transient_state() was wiping ALL SHOPT_* variables between exec() calls, including shopt options like expand_aliases. This made alias expansion impossible when shopt and alias commands were in separate exec() calls (the JS/Python API pattern). Now only `set` options (SHOPT_e, SHOPT_x, etc.) are reset between exec() calls for safety (TM-ISO-023), while `shopt` options (expand_aliases, extglob, dotglob, etc.) persist as session config. Closes #1130
set options are now properly cleared between exec() calls via SET_OPTION_VARS in reset_transient_state().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset_transient_state()was wiping ALLSHOPT_*variables betweenexec()calls, includingshoptoptions likeexpand_aliases. This made alias expansion impossible whenshoptandaliascommands were in separateexec()calls (the JS/Python API pattern).setoptions (SHOPT_e,SHOPT_x, etc.) are reset betweenexec()calls for safety (TM-ISO-023), whileshoptoptions (expand_aliases,extglob,dotglob, etc.) persist as session configuration.Test plan
alias_expansion_persists_across_exec_callsverifies aliases work across separateexec()callsset_e_does_not_leak_between_execconfirmsset -eis still properly resetthreat_isolation_alias_isolationconfirms cross-session alias isolationCloses #1130